Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/117 empty files #121

Merged
merged 2 commits into from
Oct 15, 2023
Merged

Feat/117 empty files #121

merged 2 commits into from
Oct 15, 2023

Conversation

credmond-git
Copy link
Collaborator

feat: all loaders support empty configs. Will return an empty map. #117

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4939bcd) 85.20% compared to head (ebe2adf) 85.21%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #121   +/-   ##
=========================================
  Coverage     85.20%   85.21%           
- Complexity     1723     1727    +4     
=========================================
  Files           167      167           
  Lines          4847     4855    +8     
  Branches        603      607    +4     
=========================================
+ Hits           4130     4137    +7     
- Misses          507      508    +1     
  Partials        210      210           
Files Coverage Δ
.../github/gestalt/config/loader/MapConfigLoader.java 100.00% <100.00%> (ø)
...g/github/gestalt/config/loader/PropertyLoader.java 89.65% <100.00%> (+0.76%) ⬆️
...ava/org/github/gestalt/config/yaml/YamlLoader.java 84.74% <100.00%> (+0.53%) ⬆️
...b/gestalt/config/loader/EnvironmentVarsLoader.java 90.00% <0.00%> (-10.00%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@credmond-git credmond-git merged commit 9768add into main Oct 15, 2023
3 of 4 checks passed
@credmond-git credmond-git deleted the feat/117-empty-files branch October 15, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant